John W. Linville wrote: > > Yeah, I don't like the original version either. Even if the kmalloc's > aren't a big performance hit, the failure path sucks. I've included a > new version below, but unfortunately I haven't had a chance to test it. > Please give it a try if you get a chance? This one tests just fine here running on the latest pull of wireless testing (v2.6.30-rc4-22732-gd879ac6). I think there is a leak of priv->io_dmabuf when the driver is unloaded, and kfree(priv->io_dmabuf) should be added to rtl8187_disconnect(). Otherwise ACK. Larry -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html