Hi Daniel, > > > http://thread.gmane.org/gmane.linux.kernel.wireless.general/25001 > > > > No, I haven't. Yep, my solution is really too simple. I like the > > virtual air grouping. I'll implement it. > > After a bit studying how to use configfs (and getting a bit lost) > I found netconsole.c which uses configfs. So this version is a copy&past > thing. Of course, this needs more work. > > Is this what do did have in mind? Very cool. We had a patch at some point to add configfs support to hwsim but it seems it got lost :( But I don't think your configfs support is optimal since you need to create those dirs for phy0 and put the name in etc. even when phy0 already exists. I'm sorry to have wasted your time with the configfs suggestion, but I think with how hwsim _currently_ behaves, without configfs support for creating new radios etc., putting this into debugfs would be nicer, since debugfs already has a dir for this from cfg80211/mac80211... > +config MAC80211_HWSIM_VGROUP > + bool "enable virtual air grouping" > + depends on MAC80211_HWSIM > + default y > + help > + This option enables virtual air grouping. > + > + If unsure, say N. I also wouldn't make it configurable, just make it default to group == 1 so that it behaves as it was. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
