Search Linux Wireless

Re: [ath5k-devel] ath5k: scanning while transmitting causes oops on 802.11a capable card

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2009-05-06 at 16:12 -0400, Pavel Roskin wrote:

> > > > If I scan by "iw dev wlan0 scan" while sending data through the
> > > > interface, I get a BUG in net/mac80211/tx.c:
> > > 
> > > Agreed... Also I think the same thing happens for rx for ath5k,
> > > explaining the 'unknown rate index' warnings (sc->curband changes
> > > during scan but we process a beacon from 2ghz band, that one at
> > > least just needs some synchronization in the driver).
> > 
> > Ah, that could be -- I sure am tired of reading bug reports about
> > that...
> 
> I've bisected it.  The problem is introduced by the commit
> 2038ccfbb5f7fc7d8bca26bf53bdd6c7778136ff:
> 
> Author:     Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> AuthorDate: Wed Apr 29 12:26:17 2009 +0200
> Commit:     John W. Linville <linville@xxxxxxxxxxxxx>
> CommitDate: Thu Apr 30 15:06:34 2009 -0400
> 
>     mac80211: tell driver when idle

Huh? That's confusing. Also, you say you get a BUG but point out a
WARN_ON_ONCE, was that an oversight or does something crash there?

OTOH, I can see one thing happening -- it would access scan_channel.
Patch should fix that, does it help?

johannes

--- wireless-testing.orig/net/mac80211/iface.c	2009-05-06 22:25:45.000000000 +0200
+++ wireless-testing/net/mac80211/iface.c	2009-05-06 22:25:53.000000000 +0200
@@ -964,5 +964,6 @@ void ieee80211_recalc_idle(struct ieee80
 	mutex_lock(&local->iflist_mtx);
 	chg = __ieee80211_recalc_idle(local);
 	mutex_unlock(&local->iflist_mtx);
-	ieee80211_hw_config(local, chg);
+	if (chg)
+		ieee80211_hw_config(local, chg);
 }


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux