Le mardi 28 avril 2009 à 22:18 +0200, Ivo Van Doorn a écrit : > On Tue, Apr 28, 2009 at 8:57 PM, John W. Linville > <linville@xxxxxxxxxxxxx> wrote: > > On Sun, Apr 26, 2009 at 04:09:11PM +0200, Ivo van Doorn wrote: > >> From: Alban Browaeys <prahal@xxxxxxxxx> > >> > >> extra parenthesis made the value an argument and the value of the > >> define empty. This was triggering those very fast. > >> > >> Signed-off-by: Alban Browaeys <prahal@xxxxxxxxx> > >> Signed-off-by: Ivo van Doorn <IvDoorn@xxxxxxxxx> > > > > ??? > > > > If that were so, wouldn't that have caused compile-time errors? > > I've CCed Alban so he can explain the issue he experienced.. > > For me this patch is just a style-fix, because those > parenthesis were useless anyway. Right this is only style change. Not that when I sent it I thought : #define A (x) was like: #define A(X)() thus the patch and the comment. Thankfully it does not hurt though it does not help either . My getting the issue fixed was that I had EV_KEY instead of EV_SW for the rfkill switch. I mixed the results of this test and the one about this patch. By the way I found out that I had rfkill-input loaded for no good reason (only because the debian eeepc acpi support package load it at boot). If one load it at the same time as rt2800pci crash follows next rfkill switch. That could be due to the init of the rfkill-input module that register a handler to input subsystem. Its connect operation triggers a start which itself triggers the EV_SW,and swbit code of its device. Thus it would explain that the device is shut down at registration of the input_register_polled_device. This is minor as on eeepc the status is always on (when off the device is out of power and thus no status is available) and the rfkill for wlan is already managed by eeepc-laptop platform driver. One only need not have rfkill-input loaded which is the default on debian and may be required by other uses . Regards, Alban PS: sorry for the mistake and the time I took to tell about it. Finding out the real culprit of the crash/invalid behaviour (crash is new ... reproducible though) took time. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
