Search Linux Wireless

[PATCH] mac80211: fix basic rate bitmap calculation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



    commit d61272cbb35fa1c08fe94898583d880256f2dbd3
    Author: Tomas Winkler <tomas.winkler@xxxxxxxxx>
    Date:   Thu Oct 30 17:08:08 2008 +0200

        mac80211: fix basic rates setting from association response
        
        In previous code all the rates were marked as basic.
        
        Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
        Signed-off-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
        Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx>

introduced a copy/paste error (see patch).

Unfortunately, this not just leads to wrong data being passed
to the driver but is remotely exploitable for some hardware or
driver combinations.

Signed-off-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
Cc: stable@xxxxxxxxxx [2.6.29]
---
 net/mac80211/mlme.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- wireless-testing.orig/net/mac80211/mlme.c	2009-04-19 12:27:46.000000000 +0200
+++ wireless-testing/net/mac80211/mlme.c	2009-04-19 12:27:51.000000000 +0200
@@ -1577,7 +1577,7 @@ static void ieee80211_rx_mgmt_assoc_resp
 
 	for (i = 0; i < elems.ext_supp_rates_len; i++) {
 		int rate = (elems.ext_supp_rates[i] & 0x7f) * 5;
-		bool is_basic = !!(elems.supp_rates[i] & 0x80);
+		bool is_basic = !!(elems.ext_supp_rates[i] & 0x80);
 
 		if (rate > 110)
 			have_higher_than_11mbit = true;


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux