> + if (changed & WIPHY_PARAM_RTS_THRESHOLD) { > + if (local->ops->set_rts_threshold) > + local->ops->set_rts_threshold(local_to_hw(local), > + wiphy->rts_threshold); > + } That could return an error. (so do the changes the other way around) > + if (changed & WIPHY_PARAM_RETRY_SHORT) > + rdev->wiphy.retry_short = retry_short; > + if (changed & WIPHY_PARAM_RETRY_LONG) > + rdev->wiphy.retry_long = retry_long; > + if (changed & WIPHY_PARAM_FRAG_THRESHOLD) > + rdev->wiphy.frag_threshold = frag_threshold; > + if (changed & WIPHY_PARAM_RTS_THRESHOLD) > + rdev->wiphy.rts_threshold = rts_threshold; > + > + result = rdev->ops->set_wiphy_params(&rdev->wiphy, changed); > + if (result) > + goto bad_res; > + } If that returns an error we need to roll back the values? johannes
Attachment:
signature.asc
Description: This is a digitally signed message part