Search Linux Wireless

Re: [RFC 1/3 v2] mac80211: improve powersave implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes:

> When you have multiple virtual interfaces the current
> implementation requires setting them up properly from
> userspace, which is undesirable when we want to default
> to power save mode. Keep track of powersave requested
> from userspace per managed mode interface, and only
> enable powersave globally when exactly one managed mode
> interface is active and has powersave turned on.
>
> Second, only start the dynPS timer when PS is turned
> on, and properly turn it off when PS is turned off.
>
> Third, fix the scan_sdata abuse in the dynps code.
>
> Finally, also reorder the code and refactor the code
> that enables PS or the dynps timer instead of having
> it copied in two places.

The code is a lot cleaner now, thanks for doing this.

Unfortunately I don't have time to do proper review or testing right
now, but after a quick look this looks good.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux