2009/4/15 Johannes Berg <johannes@xxxxxxxxxxxxxxxx>: > On Wed, 2009-04-15 at 00:34 +0200, Gábor Stefanik wrote: >> Set the total count of TX tries to 1 if IEEE80211_TX_CTL_NO_ACK is >> set. This fixes a bug where mac80211 allowed the RC algo to request >> drivers to forcibly retransmit NO_ACK (e.g. multicast) frames until >> the excessive-retries limit is reached. > > Why not fix the rate control algorithms to use the no-ack flag instead > of is_multicast? I was thinking about that originally, but we have 5 RC algorithms (minstrel, pid, iwl-3945-rs, iwl-agn-rs & ath9k-rs) right now, with possibly more to come for future N-based devices. Fixing them all one-by-one would be much more tedious, and we will still not be future-proof (that is, there is always the risk of getting a new driver released with its own, specific RC algorithm that suffers from this bug). This way, if e.g. Whatevercom releases a driver for its WhateWIFI UltraMIMO1337 chipset with its own, buggy "whatever-rs" algorithm, NO_ACK will still work properly for that driver. > >> Signed-off-by: Gábor Stefanik <netrolller.3d@xxxxxxxxx> >> Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> >> >> --- >> Patch also available as attachment in case Gmail linewraps it. > > You need to get a proper MUA. Well, if you know any MUA that does Gmail-style conversation threading, and can sync its conversations with the Gmail web interface (I need access to Gmail on the go, including from public computers where I can't install a MUA), tell me immediately. So far, I've seen no such thing. > > johannes > -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
