Em Segunda-feira 13 Abril 2009, às 13:03:25, Larry Finger escreveu:
> The following patch implements some control over the LED on RTL8187B and
> RTL8187L devices. Triggers are registered for TX and RX. Whenever the
> trigger event occurs, the LED is turned off for 1/20 second, then turned
> back on.
>
> Note: For those RTL8187X devices that are built into the computer and have
> a LED that is expected to be controlled with a radio switch, this patch
> will not operate that LED. That will take a separate patch to be prepared
> later.
>
> Please test and comment.
>
> The behavior described above is found for my Level One RTL8187B. Prior to
> this patch, the LED was on continuously. On a Netgear WG111V2 RTL8187L, the
> LED blinks erratically. Before the patch, the LED was off.
>
> If you test, please report the status of the LED before and after applying
> the patch. In addition, find the line that looks like "rtl8187: Customer ID
> 0x00" in the dmesg output and report it. I also need to know if you have a
> B or L model.
I tested here on a Quanta IL1 mini-notebook with rtl8187b:
- Reports Customer ID 0x00
- Before the patch, on a cold boot, when driver loads, the wireless led lights
up and stays forever on (expected, one of the register writes from
rtl8187b_reg_table turns it on: {0x91, 0x03, 0}, this should be removed from
the code and turn led up now in rtl8187_leds_init may be?).
- After the patch it continues to turn on as expected (nothing changed), and
blinks on activity, is working fine. But it doesn't turn off led on unregister,
missing led_turn_off at rtl8187_unregister_led. Otherwise looks fine.
BTW, thanks for doing this, led support is a nice feature :)
>
> A number of problems with version 1 of this patch have been fixed. The most
> important of these was a locking problem that caused the RTL8187L to fail.
>
> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> ---
>
<snip>
--
[]'s
Herton
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
