Johannes Berg wrote: > On Sun, 2009-04-12 at 19:40 -0500, Larry Finger wrote: > >> - rtl818x_iowrite16(priv, (__le16 *)0xFFF4, 0xFFFF); >> + rtl818x_iowrite16(priv, &priv->map->FEMR, 0xFFFF); > > That looks strange -- I can tell it works because priv->map is set to > 0xFF00, but wouldn't actual constants make more sense? The value 0xFFF4 is the address offset of the Function Event Mask Register, not a data value. Using a symbol emphasizes that we are referring to a register and not a constant. Larry -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
