>
> My first comment is that the patch should be in-line rather than as an
> attachment. Reviewing is easier.
>
> You should be using the wireless-testing tree to derive your patches.
> Otherwise,
> they cannot be applied. For example, the following hunk is already in
w-t:
>
> @@ -257,6 +261,7 @@
>
> usb_fill_bulk_urb(urb, priv->udev, usb_sndbulkpipe(priv->udev,
> ep),
> buf, skb->len, rtl8187_tx_cb, skb);
> + urb->transfer_flags |= URB_ZERO_PACKET;
> rc = usb_submit_urb(urb, GFP_ATOMIC);
> if (rc < 0) {
> usb_free_urb(urb);
>
>
> I don't like the idea of having the antenna diversity as a compile-time
> option.
> That works OK for a single user, but it fails when distros are
considered.
> They
> would have to have it on for all cases even though very few users would
> need it.
> Does the EEPROM for your device have special encoding that indicates the
> presence of multiple antennas? You should be able to compile the antenna
> diversity code unconditionally and use such a special EEPROM value.
> Alternatively, the USB ID's (13d1:abe6) could be used to select its
> execution.
>
> You should run the patch through the scripts/checkpatch.pl routine. Yours
> shows
> 55 errors and 34 warnings.
>
> Please split out the part that adds the new USB_DEVICE and submit it now.
> That
> will be needed no matter what happens to the antenna diversity code.
>
> Larry
> --
Hello Larry, thanks for comments! Surely Eugene will fix patch issues and
resubmit patch inline. Actually in its current stage this patch just show
an
diversity idea and will be cleaned-up for submission with Signed-off-by.
Currently the question was about correctness of calculation of signal
quality
and making decision when switching between antennas should be done. Anyway
it will be easier to say about this when patch will be inline.
Btw, USB_DEVICE is already added: http://lkml.org/lkml/2008/11/17/39
Best regards,
Ivan
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
