Christian Lamparter wrote: > I'm thinking of splitting up p54common.c into small files... > e.g: one file each for eeprom, mac, led and main/lib code. > So I'm asking for your opinion "before" I waste time with it. Christian, With this patch applied, p54common.c is 77K characters, which is on the edge of being unwieldy. I would not object to splitting it into the 4 categories you mention. As we are roughly 2 months from the 2.6.31 merge, this might be a good time to do it as there would be plenty of time for testing. I have not yet tested this patch as I'm currently chasing a regression in 2.6.30-rc1 from Linus's tree. Once that is squared away, then I'll test the channel list changes. I do approve of the concept. Larry -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html