Johannes Berg wrote: > Larry, > >> I'm having trouble getting the radio LED to work on b43legacy. When the LED's >> are registered, I get LED index 0 registered with names of "b43legacy-phy0::tx" >> and "b43legacy-phy0::rx", and LED index 1 with a name as of >> "b43legacy-phy0::radio". I placed printk's at the entrance to >> b43legacy_led_brightness_set(), which is the callback routine. I see a number of >> calls to modify LED index 0, which I assume are due to RX/TX activity, but only >> a single call for LED index 1 when the LED's are still being registered. There >> are no such calls generated when the radio switch is moved. >> >> I don't see where/how a particular LED is attached to the rfkill event. Could >> you point me to some code that does that? > > In theory, that is here: > > snprintf(name, sizeof(name), > "b43legacy-%s::radio", wiphy_name(hw->wiphy)); > b43legacy_register_led(dev, &dev->led_radio, name, > b43legacy_rfkill_led_name(dev), > led_index, activelow); > > I actually thought this was attached, by default, to the mac80211 radio > trigger, not the rfkill radio trigger. > > Can you check the contents of > /sys/class/leds/b43legacy-...::radio/trigger > please? The first thing I noticed is that "radio" gets truncated to "rad", thus the file is /sys/class/leds/b43legacy-phy0\:\:rad/trigger, with contents "none ide-disk ADP1-online BAT0-charging-or-full BAT0-charging BAT0-full phy0rx phy0tx phy0assoc phy0radio [(]". I unloaded and reloaded the driver and found that the "[(]" characters changed to "[�W[�]". It appears that something is putting garbage in that file. Larry Larry -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
