Search Linux Wireless

Re: [PATCH v3 3/3] cfg80211: send regulatory beacon hint events to userspace

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2009-04-01 at 21:35 -0400, Luis R. Rodriguez wrote:

> +void nl80211_send_beacon_hint_event(struct wiphy *wiphy,
> +				    struct ieee80211_channel *channel_before,
> +				    struct ieee80211_channel *channel_after)
> +{
> +#define NL80211_PUT_BC_CHAN(_attr, _chan) do { \
> +	nl_freq = nla_nest_start(msg, _attr); \
> +	if (!nl_freq) \
> +		goto nla_put_failure; \
> +	if (nl80211_msg_put_channel(msg, _chan)); \
> +		goto nla_put_failure; \
> +	nla_nest_end(msg, nl_freq); \
> +} while (0)

Please just open-code that, and there's a ; too much after the if.

Otherwise good series, thanks.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux