On Fri, 2009-03-27 at 11:36 -0300, Henrique de Moraes Holschuh wrote: > On Fri, 27 Mar 2009, Johannes Berg wrote: > > There's a lot of rfkill-input code that cannot ever be > > compiled and is useless until somebody needs and tests > > it -- therefore remove it. > > Just so that you guys know, that code *is* tested :-) At some point :) > I'd suggest that the code removal be done leaving a comment in place, like this: > > /* Currently, code to implement EV_SW SW_WLAN/WWAN/BLUETOOTH/etc is not > * in place since it was unused and was therefore removed. Please look > * at past history to check how it was supposed to be done, if you need > * to implement handling for EV_SW. > */ > > Because that codepath is _not_ the most obvious thing in the world to > reimplement without hitting a pitfall, so people better look how it was done > once in time... Works for me. Do we expect it to be needed though? johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
