Search Linux Wireless

Re: [PATCH 2/3] iwlwifi: remove STATUS_ALIVE checking from rf_kill

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi John,

On Fri, 2009-03-27 at 09:03 -0700, reinette chatre wrote:
> On Thu, 2009-03-26 at 23:18 -0700, Helmut Schaa wrote:
> > Hi again,
> > 
> > Am Donnerstag, 26. März 2009 schrieb Reinette Chatre:
> > > Remove STATUS_ALIVE checking when HW RF KILL disabled, the bit get
> > > clear in __iwl_down() function; the additional checking will fail and
> > > cause RF can not be turn back on.
> > 
> > Maybe just checking for is_open instead of STATUS_ALIVE will fix the issue
> > too? I only had a quick look but it looks possible. AFAICS is_open indicates
> > if the interface was taken up by mac80211. So if the interface is up but
> > STATUS_ALIVE is not set we want to restart the adapter after unkilling but
> > if the interface is still down (is_open==0) we do not want to restart the
> > adapter. Furthermore, is_open is also set in case the interface was taken
> > up but wireless was rfkilled.
> 
> Very good idea ... I'm looking into this.

Could you please drop this patch? We will send a new fix for this
problem using Helmut's suggestion.

Thank you

Reinette

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux