On Tue, 2009-03-24 at 21:31 -0700, TJ wrote: > On Wed, 2009-03-25 at 11:41 +0800, Huaxu Wan wrote: > > Hi, > > > > This issue is confirmed here too. But during compile, there is warning about > > cancel_work_sync(), cancel_delayed_work_sync() should be used instead. > > > > And, without the modification in iwl3945_rfkill_poll() and > > iwl3945_mac_stop(), just with one line cancel_delayed_work_sync(), this issue > > is also fixed in my testing. > > Originally I did try adding just cancel_delayed_work_sync() although I > put it immediately following: > > iwl3945_rfkill_unregister(priv); > cancel_delayed_work(&priv->rfkill_poll); > > Wondered why that didn't work and hunted down the unnecessary calls to > queue_delayed_work() that were causing the issue and made them > conditional on STATUS_EXIT_PENDING. > > Then I decided to be absolutely sure and moved cancel_delayed_work() > further down and for some reason mis-used cancel_work_sync() instead of > cancel_delayed_work_sync() - not paying attention I guess! Sounds like this can be done in one line ... could you please resubmit? Thanks Reinette -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
