On Tue, Mar 24, 2009 at 7:30 PM, Luis R. Rodriguez <lrodriguez@xxxxxxxxxxx> wrote: > On Tue, Mar 24, 2009 at 6:06 PM, Bob Copeland <me@xxxxxxxxxxxxxxx> wrote: >> On Tue, Mar 24, 2009 at 04:52:09PM -0700, Luis R. Rodriguez wrote: >>> Alright here's a quick concat of all these patches (also one small >>> sparse fix on Christian's last patch). It also now throws ath5k, ath9k >>> and ar9170 into ath/. We can rename the drivers after, was lazy to do >>> that. Think its easier for review to separate that too. >>> >>> http://bombadil.infradead.org/~mcgrof/patches/ath/ath-common-v3.patch.txt >>> >>> Bob, where was that switch break error? >> >> 1st patch: >> >>> + switch (band) { >>> + case IEEE80211_BAND_2GHZ: >>> + ctl = ah->regulatory.regpair->reg_2ghz_ctl; >>> + case IEEE80211_BAND_5GHZ: >>> + ctl = ah->regulatory.regpair->reg_5ghz_ctl; >>> + default: >>> + ctl = NO_CTL; >>> + } >>> + return ctl; >>> +} >> >> I think I had it like the following and changed it -- actually with >> the returns it's probably better... >> >> switch (band) { >> case XXX: >> return ah->...; >> case YYY: >> ... >> } > > Alright thanks, I've fixed that here, it also now does not introduce > any new checkpatch or sparse complaints. > > http://bombadil.infradead.org/~mcgrof/patches/ath/ath-common-v4.patch.txt > > My shiny new wl rebased on 29 kernel is compiling, will let you know > in the morning how it goes. Ah poo, ath5k_reg_notifier() got lost. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
