Luis R. Rodriguez <mcgrof@...> writes: > > If reg_is_world_roaming is modified to check for last_request not being > > NULL, e.g. > > if (last_request && last_request->initiator != REGDOM_SET_BY_COUNTRY_IE > > && > > then I also get an oops in reg_device_remove where last_request is > > referenced and there is only a subsequent check for it being NULL. Following the commits included in master-2009-03-23, in function reg_device_remove in net/wireless/reg.c there is still a dereference via last_request (request_wiphy = wiphy_idx_to_wiphy(last_request->wiphy_idx);) prior to the test for last_request != NULL (if (!last_request || !request_wiphy) ) I suspect that following the patches applied, last_request cannot be NULL, and therefore the check !last_request is not required; otherwise the check needs to be made before the call to wiphy_idx_to_wiphy. One way or the other, as it stands the code looks wrong. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
