Search Linux Wireless

Re: [PATCH 5/5] ar9170: update Makefile, Kconfig and MAINTAINERS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2009-03-21 at 23:11 +0100, Christian Lamparter wrote:

> +config AR9170_COMMON
> +	tristate "Atheros AR9170 support"
> +	depends on WLAN_80211 && MAC80211 && EXPERIMENTAL
> +	help
> +	  This is common code for AR9170 based devices.
> +	  This module does nothing by itself - the USB/(SPI) frontends
> +	  also need to be enabled in order to support any devices.
> +
> +	  Say Y if you have the hardware, or M to build a module called
> +	  ar9170common.
> +
> +config AR9170_USB
> +	tristate "Atheros AR9170 USB support"
> +	depends on AR9170_COMMON && USB
> +	select FW_LOADER
> +	help
> +	  This is a driver for the Atheros "otus" 802.11n USB devices.
> +
> +	  These devices require additional firmware (2 files).
> +	  For now, these files can be downloaded from here:
> +	  http://wireless.kernel.org/en/users/Drivers/ar9170
> +
> +	  If you choose to build a module, it'll be called ar9170usb.
> +
> +config AR9170_LEDS
> +	bool
> +	depends on AR9170_COMMON && MAC80211_LEDS && (LEDS_CLASS = y || LEDS_CLASS = AR9170_COMMON)
> +	default y
> diff --git a/drivers/net/wireless/ar9170/Makefile b/drivers/net/wireless/ar9170/Makefile
> new file mode 100644
> index 0000000..3f0e468
> --- /dev/null
> +++ b/drivers/net/wireless/ar9170/Makefile
> @@ -0,0 +1,5 @@
> +ar9170common-objs += main.o cmd.o mac.o phy.o led.o
> +ar9170usb-objs += usb.o
> +
> +obj-$(CONFIG_AR9170_COMMON) += ar9170common.o
> +obj-$(CONFIG_AR9170_USB) += ar9170usb.o

I think it would make sense to link them into the same module as long as
we don't have a second user of the common code. I actually doubt we will
see a second user of the common code at all, even if it is in theory
possible with the hardware design.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux