Search Linux Wireless

Re: [PATCH] Marvell CF8381

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -       priv->regioncode = le16_to_cpu(cmd.regioncode) & 0xFF;
> +       priv->regioncode = (le16_to_cpu(cmd.regioncode) & 
0xFF00) >> 8;

Hmm, the change that this breaks 8385 is quite high, maybe 100
percent.

It could simply be the case that your firmware returns the value
in a different order than mine. So we either need to test for the
firmware version or for the hardware before getting the value via
one or the other method.

Maybe it's worthwhile to create some hw_is_8381() function and 
then do the things that need to be differently based on it's 
return value?



The documentation for CMG_GET_HW_SPEC that I have says

RegionCode   UINT16    Set to 0

so I see no indicator that we have two 8 bit values here. But
we've seen bugs in docs before :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux