On Sat, 2009-03-21 at 12:20 +0100, Michael Buesch wrote:
> > > > +#if 0
> > > > +#include <linux/mutex.h>
> > > > +#define mutex_lock(m) do { mutex_lock(m); __acquire(m); } while (0)
> > > > +#define mutex_unlock(m) do { mutex_unlock(m); __release(m); } while (0)
> > > > +#endif
> > > > +
> > > > +#endif /* __USB_H */
> > >
> > > Whoops, debugging code? :)
> >
> > sparse, for some reason mutex operations aren't annotated... Probably
> > because Ingo wrote the code...
>
> Well I think it would currently generate lots of errors, because we have
> code like this in the kernel:
>
> if (x)
> mutex_lock();
> ...
> if (x)
> mutex_unlock();
That's sloppy code anyway. Not to be encouraged.
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
