Search Linux Wireless

Re: [PATCH v2] Fix SLAB corruption during rmmod

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 16, 2009 at 08:24:27PM +0100, Ivo van Doorn wrote:
> At rmmod stage, the code path is the following one :
> 
> rt2x00lib_remove_dev
>   ->  rt2x00lib_uninitialize()
>         -> rt2x00rfkill_unregister()
>              -> rfkill_unregister()
>         -> rt2x00rfkill_free()
>              -> rfkill_free()
> 
> The problem is that rfkill_free should not be called after rfkill_register
> otherwise put_device(&rfkill->dev) will be called 2 times. This patch
> fixes this by only calling rt2x00rfkill_free() when rt2x00rfkill_register()
> hasn't been called or has failed.
> 
> Signed-off-by: Gertjan van Wingerde <gwingerde@xxxxxxxxx>
> Tested-by: Arnaud Patard <apatard@xxxxxxxxxxxx>
> Signed-off-by: Ivo van Doorn <IvDoorn@xxxxxxxxx>
> 
> ---
> John, this patch is for 2.6.29 and only 2.6.29 since rfkill support itself
> was removed from later versions (replaced by input_polldev).
> The patch is quite big to be merged in a late state of the release cycle,
> but since the SLAB corruption is a serious problem, I hope this can get in regardless.

Could you send me a version of this that applies on top of
wireless-testing?

Also, is there a bug report somewhere that describes this issue
this addresses?

Thanks,

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@xxxxxxxxxxxxx			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux