Johannes Berg wrote:
> On Mon, 2009-03-16 at 15:35 +0530, Sujith wrote:
>
> > + /* Tear down aggregation sessions */
> > + if (hw->flags & IEEE80211_HW_AMPDU_AGGREGATION) {
> > + list_for_each_entry(sta, &local->sta_list, list) {
> > + set_sta_flags(sta, WLAN_STA_SUSPEND);
> > + ieee80211_sta_tear_down_BA_sessions(sta);
> > + }
> > + }
>
> Doesn't that, and the corresponding code in resume, need to be using the
> rcu-safe list iteration primitives and rcu_read_lock(), or acquire the
> sta_lock like the other iteration? While we should be more or less
> quiescent at this point, I wouldn't really want to bet on it.
Ah, right, it should be rcu-protected.
Will send out a v3 tomorrow.
Sujith
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
