2009/3/15 Jiri Slaby <jirislaby@xxxxxxxxx>: > On 15.3.2009 21:17, Nick Kossifidis wrote: >> >> +ath5k_get_pcdac_intercepts(struct ath5k_hw *ah, u8 min, u8 max, u8 *vp) >> +{ >> + const static u16 intercepts3[] = >> + { 0, 5, 10, 20, 30, 50, 70, 85, 90, 95, 100 }; >> + const static u16 intercepts3_2[] = >> + { 0, 10, 20, 30, 40, 50, 60, 70, 80, 90, 100 }; > > Just for future, C99 section 6.11.5 says: > Storage-class specifiers > The placement of a storage-class specifier other than at the > beginning of the declaration specifiers in a declaration is > an obsolescent feature. > > It means we should use 'static const' instead of 'const static'. > ACK i think we should do a cleanup patch and deal with such issues all over ath5k > Otherwise it looks good, thanks. Do you want me to resend or is it ok by you ? -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html