Search Linux Wireless

Re: [PATCH v2] mac80211: resume properly, add suspend/resume test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 13, 2009 at 6:58 AM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
>> ath9k survives ping -f without even blinking.
>
> Actually, not quite:
>
> [  289.753866]
> [  289.753869] =================================
> [  289.754164] [ INFO: inconsistent lock state ]
> [  289.754372] 2.6.29-rc7-wl-17155-g2f7ab92-dirty #29
> [  289.754598] ---------------------------------
> [  289.754805] inconsistent {in-softirq-W} -> {softirq-on-W} usage.

[softirq-on-W stack looks like:

  sta_notify
    ath_node_detach
      ath_tx_node_cleanup
        spin_lock()

vs the ath9k_tx_tasklet]

> Looks like we need to disable BHs for the sta functions or something?
>
> johannes

Yup... or pm can take sta_lock with spin_lock_irqsave() like the other
callers of sta_notify.

Feel free to add my Acked-by on both the PM patches.  I'd been using
CONFIG_PM_DEBUG to simulate suspend/resume but since you have to
do 'devices' anyway to get the desired effect, the debug file here
is nicer.

-- 
Bob Copeland %% www.bobcopeland.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux