Am Dienstag, 10. März 2009 schrieb Luis R. Rodriguez:
> This informs userspace when a change has occured on a world
> roaming wiphy's channel which has lifted some restrictions
> due to a regulatory beacon hint.
>
> Because this is now sent to userspace through the regulatory
> multicast group we remove the debug prints we used to use as
> they are no longer necessary.
>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@xxxxxxxxxxx>
> ---
>
> There is something awefully wrong with this patch and after some
> good review I cannot determine what is wrong with it. The issue is
> I end up following bug complaint saying I'm sleeping while I'm atomic..
> but this is all from a workqueue so what gives?
>
> I have to be missing something obvious or could this be another issue?
The code is sleeping while holding a spinlock (see reg_process_pending_beacon_hints).
[...]
> +void nl80211_send_beacon_hint_event(struct wiphy *wiphy,
> + struct ieee80211_channel *channel_before,
> + struct ieee80211_channel *channel_after)
> +{
> + struct sk_buff *msg;
> + void *hdr;
> + struct nlattr *nl_freqs, *nl_freq;
> + struct ieee80211_channel *chan;
> + unsigned int i;
> +
> + msg = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
Just using GFP_ATOMIC here should be fine.
Helmut
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
