Sujith írta:
> Gabor Juhos wrote:
>> Apart from the last line, this patch simply swaps the two initval sets as i see
>> it. Would not be simpler to rename them, and then change this line only?
>>
>
> I didn't bother to check if the initvals were to be swapped or not.
Well, I was curious, so I did it. :)
After some cut&paste job, here is the diff between the original and the new
initvals from your patch:
diff --git a/drivers/net/wireless/ath9k/initvals.h
b/drivers/net/wireless/ath9k/initvals.h
index d492363..d5a8aec 100644
--- a/drivers/net/wireless/ath9k/initvals.h
+++ b/drivers/net/wireless/ath9k/initvals.h
@@ -658,7 +657,7 @@ static const u32 ar5416Addac_9100[][2] = {
{0x0000989c, 0x00000000 },
{0x0000989c, 0x00000000 },
{0x0000989c, 0x00000000 },
- {0x000098cc, 0x00000000 },
+ {0x000098c4, 0x00000000 },
};
static const u32 ar5416Modes[][6] = {
@@ -862,7 +861,7 @@ static const u32 ar5416Common[][2] = {
{ 0x00008134, 0x00000000 },
{ 0x00008138, 0x00000000 },
{ 0x0000813c, 0x00000000 },
- { 0x00008144, 0x00000000 },
+ { 0x00008144, 0xffffffff },
{ 0x00008168, 0x00000000 },
{ 0x0000816c, 0x00000000 },
{ 0x00008170, 0x32143320 },
> The patch was a line-by-line copy of the latest initvals. :-)
> Figured this would also make it easier to roll out future updates.
Ok. This version will cause more noise, but it is fine for me.
>
>>> +#define AR_SREV_VERSION_9100 0x014
>> 0x14?
>
> Yep, this can be fixed.
I have to send a new patch, or you will take care of it?
Regards,
Gabor
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
