Vivek Natarajan wrote: > SC_OP_WAIT_FOR_BEACON is being changed in rx_tasklet and in isr which > are mutually exclusive. Even though it might be changed in these two > regions, it won't affect the ps_wake/ps_restore cycle. > > IEEE80211_CONF_PS is changed in siwpower() and also in > dynamic_ps_work. Even if it is changed while we are executing this > ps_restore, there won't be any race condition on ps_wake/ps_restore > cycle and it will work fine. > > hw_setpower is just a register write function which may not need a protection(?) > > And for the protection of ps_wake/ps_restore itself, there is > ps_count(atomic) which takes care of properly restoring power save > state. > > Overall, from my perspective there is no need for any more lock. Sorry, I saw sc_flags and just assumed it would be set from process context. Thanks for the explanation. Sujith -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
