Search Linux Wireless

Re: [PATCH 2/6] iwl3945: synchronize timestamp with uCode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2009-02-27 at 18:06 -0800, Sujith wrote:
> Reinette Chatre wrote:
> > From: Abhijeet Kolekar <abhijeet.kolekar@xxxxxxxxx>
> > 
> > In IBSS, TSF maintains local clock counters at each station. Network
> > Synchronization follows a completely distributed scheme where beacon frames
> > are generated. Each station maintain its own TSF timestamp, extracted from
> > beacon timestamps they recieved. Following patch synchronize this beacon timestamp
> > with uCode.
> > 
> > Signed-off-by: Abhijeet Kolekar <abhijeet.kolekar@xxxxxxxxx>
> > Signed-off-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>
> > ---
> >  drivers/net/wireless/iwlwifi/iwl3945-base.c |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> > index 6dcc577..443c00e 100644
> > --- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
> > +++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> > @@ -4305,6 +4305,7 @@ static int iwl3945_mac_beacon_update(struct ieee80211_hw *hw, struct sk_buff *sk
> >  {
> >  	struct iwl_priv *priv = hw->priv;
> >  	unsigned long flags;
> > +	__le64 timestamp;
> >  
> >  	IWL_DEBUG_MAC80211(priv, "enter\n");
> >  
> > @@ -4326,6 +4327,8 @@ static int iwl3945_mac_beacon_update(struct ieee80211_hw *hw, struct sk_buff *sk
> >  	priv->ibss_beacon = skb;
> >  
> >  	priv->assoc_id = 0;
> > +	timestamp = ((struct ieee80211_mgmt *)skb->data)->u.beacon.timestamp;
> > +	priv->timestamp = le64_to_cpu(timestamp);
> >  
> 
> This won't work, since the timestamp in the beacon isn't being updated in mac80211.
> See the 'IBSS Issues' thread. I attached a quick patch there.

Thanks for spotting this. There is thus not a problem with this specific
patch ... just the information it depends on, which you now fixed. Are
you going to send your fix for inclusion ?

Reinette

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux