Search Linux Wireless

Re: [PATCH] ath9k: Remove unused key xoring

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 02, 2009 at 10:20:07AM -0500, Bob Copeland wrote:
> > -       key1 = (get_unaligned_le16(k->kv_val + 4) ^ xorMask) & 0xffff;
> > -       key3 = (get_unaligned_le16(k->kv_val + 10) ^ xorMask) & 0xffff;

> > +       key1 = get_unaligned_le16(k->kv_val + 4);
> > +       key3 = get_unaligned_le16(k->kv_val + 10) & 0xffff;

> key1 lost the mask but key3 kept it?

Heh.. Interesting editing bug that probably happened when I cleaned up
some of my pending patches. I don't think the '& 0xffff' part is really
needed here in either case.
 
-- 
Jouni Malinen                                            PGP id EFC895FA
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux