On Wed, Jan 28, 2009 at 6:37 AM, Samuel Ortiz <samuel@xxxxxxxxxx> wrote: > On Wed, Jan 28, 2009 at 09:12:48AM +0200, Tomas Winkler wrote: >> On Wed, Jan 28, 2009 at 1:31 AM, Jason Andryuk <jandryuk@xxxxxxxxx> wrote: >> >> No, that's just a consequence of the bug, not the bug itself. >> >> Would you mind applying this patch on top of your latest wireless-testing tree >> >> and testing 3945 with it ? Thanks for your patience. >> > >> > The patch did not cleanly apply, but I just removed the lines >> > indicated in the patch. It crashed with a NULL pointer dereference. >> >> Samuel >> It was really wrong try, you cannot just leave place where firmware >> updated read pointer unallocated. I would rather focus on differences >> introduced by this patch. > Well, that's what I did. I neglected to check if rb_stts were actually used. > > >> commit 738910c064ff461051cd37e17199f270ff88a9a3 iwl3945: use rx queue >> management infrastructure from iwlcore is the first to trigger the >> BUG_ON. However, prior versions would dereference a NULL pointer >> before the driver could get far enough to trigger the BUG_ON. > I know, that's what Jason described. > I think I now understand why. Prior to > 738910c064ff461051cd37e17199f270ff88a9a3, you introduced > c2a0aa3cb733452e749727680e380dca6cc10a68 without actually allocating the > rb_stts pointer, which was really wrong too. I tested c2a0aa3cb733452e749727680e380dca6cc10a68 "iwl3945: use iwl_rb_status" with the additional patches to initialize rb_stts (copied from iwl_rx_queue_alloc) and to convert the BUG_ON to a WARN_ON. The driver runs without segfaulting. So far the WARN_ON has not been triggered, but the driver fails to finish authentication with the AP. I receive "wlan0: authentication with AP 00:30:bd:c0:90:24 timed out" Jason -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
