Search Linux Wireless

Re: [PATCH] ath9k: Add module parameter to disable hardware crypto

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 24 February 2009 12:42:01 Jouni Malinen wrote:
>  #define CHAN2G(_freq, _idx)  { \
> @@ -1587,7 +1591,7 @@ int ath_attach(u16 devid, struct ath_sof
>  		IEEE80211_HW_SUPPORTS_PS |
>  		IEEE80211_HW_PS_NULLFUNC_STACK;
>  
> -	if (AR_SREV_9160_10_OR_LATER(sc->sc_ah))
> +	if (AR_SREV_9160_10_OR_LATER(sc->sc_ah) || modparam_nohwcrypt)
>  		hw->flags |= IEEE80211_HW_MFP_CAPABLE;

Are you sure this is correct?
The hardware capability doesn't magically change by switching a modparam.
Either the HW is MFP capable or it isn't.

If hwcrypto is disabled (set_key returns error), mac80211 should be smart
enough to do crypto (including MFP) in software anyway.

-- 
Greetings, Michael.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux