On Mon, 2009-02-23 at 21:45 -0500, Jason Andryuk wrote: > Re-add the iwl_poll_direct_bit return value assignment dropped in Commit > 3fdd4102abceb4c99c5091674047b5c61fd3ebba "iwl3945: add apm ops". > > Signed-off-by: Jason Andryuk <jandryuk@xxxxxxxxx> > -- grep iwl_poll_direct_bit drivers/net/wireless/iwlwifi/*3945*.c drivers/net/wireless/iwlwifi/iwl-3945.c: ret = iwl_poll_direct_bit(priv, CSR_GP_CNTRL, drivers/net/wireless/iwlwifi/iwl-3945.c: iwl_poll_direct_bit(priv, FH39_TSSR_TX_STATUS, drivers/net/wireless/iwlwifi/iwl-3945.c: iwl_poll_direct_bit(priv, CSR_RESET, drivers/net/wireless/iwlwifi/iwl-3945.c: iwl_poll_direct_bit(priv, CSR_GP_CNTRL, drivers/net/wireless/iwlwifi/iwl-3945.c: rc = iwl_poll_direct_bit(priv, FH39_RSSR_STATUS, Including this patch, only two out of five return values are checked. It isn't clear to me how errors should be handled in all cases, so a maintainer should probably take a look at these. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
