Search Linux Wireless

Re: [RFC PATCH v1 2/3] mac80211: track beacons separately from the rx path activity

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2009-02-23 at 18:37 +0200, Kalle Valo wrote:

> @@ -1356,6 +1359,8 @@ static void ieee80211_rx_mgmt_assoc_resp(struct ieee80211_sub_if_data *sdata,
>  	bss_conf->assoc_capability = capab_info;
>  	ieee80211_set_associated(sdata, changed);
>  
> +	ifmgd->last_beacon = jiffies;
> +

That looks a little misplaced; I think it's actually intended anyway?
Maybe add a comment?

> -		sta->last_rx = jiffies;
> +		if (rx->sdata->vif.type == NL80211_IFTYPE_STATION &&
> +		    ieee80211_is_beacon(hdr->frame_control)) {
> +			rx->sdata->u.mgd.last_beacon = jiffies;
> +		} else
> +			sta->last_rx = jiffies;

would it be more appropriate to do that in the function that processes
the beacon in mlme.c? Or does that not work because of the workqueue and
timing?

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux