Search Linux Wireless

Re: [ath5k-devel] [PATCH] Fix transmit LED on Acer Aspire One

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 23, 2009 at 2:37 PM, John W. Linville
<linville@xxxxxxxxxxxxx> wrote:
> On Wed, Feb 18, 2009 at 02:07:05PM +1100, Peter Chubb wrote:
>> +     /* Enable softled on Acer Aspire One */
>> +     else if (pdev->subsystem_vendor == 0x105b && pdev->subsystem_device == 0xe008) {
>> +             __set_bit(ATH_STAT_LEDSOFT, sc->status);
>> +             sc->led_pin = 3;
>> +             sc->led_on = 0;
>> +     }
>>       if (!test_bit(ATH_STAT_LEDSOFT, sc->status))
>>               goto out;
>
> Any comment on this from the ath5k guys?  That 0x105b subvendor ID
> would seem to correspond to "Foxconn International, Inc.", which
> doesn't sound much like "Acer"...

It's already in wireless-testing with similar values.

Not quite apropos to this patch, someone with the ambit chipset said
the values didn't match up with his laptop, so we do need to add a
subsystem_device test I think, but it should have a #define in pci.h.
In any case there's usually no harm in enabling the wrong gpio pin,
unless rfkill happens to sit there.

-- 
Bob Copeland %% www.bobcopeland.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux