On Mon, Feb 23, 2009 at 06:41:01PM +0200, Nick Kossifidis wrote: > > No, that's intentional. That was actually a bug we had at some point > > (rs_more is a u8 so the bitwise AND overflowed). The "!!" makes it zero > > or one so it fits. > > > > AR5K_REG_MS is used for that, we should just shift it as we do with > the other fields and btw i think we must change flags to be bool. Fine with me, in fact I wrote it that way first but someone suggested "!!" instead in a patch review. Either way works. Also ACK on using bool. -- Bob Copeland %% www.bobcopeland.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html