Search Linux Wireless

Re: [PATCH] mac80211: Give it some time to do the TSF sync

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Michael Buesch <mb@xxxxxxxxx> writes:

> On Saturday 21 February 2009 22:52:02 Alina Friedrichsen wrote:
>> Give slow hardware some time to do the TSF sync, to not run into an IBSS merging endless loop in some rarely situations. 
>
> It would be great to put this into a source code comment. Without
> this knowledge one immediately gets a WTF-lookalike face when seeing
> this code.

I fully agree.

>> -	if (beacon_timestamp > rx_timestamp) {
>> +	if (beacon_timestamp > rx_timestamp && rx_timestamp > 0x400000) {

And no magic numbers, please. Create a define for that.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux