Michael Buesch wrote: > Some time ago I rejected a bunch of patches that converted the > PHY/radio register accesses to the new API. That was due to the patches > being created manually. This introduces a huge potential to add new bugs. > > However, this is an excellent task for coccinelle/spatch. > So here's a series of patches, to convert the API usage, that were generated > with spatch. This should keep the chances of breaking something as low as possible. > > This reduces the .ko size by about 6 kiB. > > The used semantic patches will be included in the patch headers. > > John, please queue these patches for the next feature release. Michael, With those patches applied on an x86_64 system, I get the following warnings: ============================ CC [M] drivers/net/wireless/b43/phy_a.o drivers/net/wireless/b43/phy_g.c: In function ‘b43_radio_interference_mitigation_enable’: drivers/net/wireless/b43/phy_g.c:974: warning: large integer implicitly truncated to unsigned type CC [M] drivers/net/wireless/b43/wa.o drivers/net/wireless/b43/wa.c: In function ‘b43_wa_altagc’: drivers/net/wireless/b43/wa.c:391: warning: large integer implicitly truncated to unsigned type drivers/net/wireless/b43/wa.c:409: warning: large integer implicitly truncated to unsigned type drivers/net/wireless/b43/wa.c:411: warning: large integer implicitly truncated to unsigned type drivers/net/wireless/b43/wa.c:421: warning: large integer implicitly truncated to unsigned type ============================ All of these occur where there is a constant of the form ~0xYXXX with Y in the range 8-F. To get rid of the warning, either use a u16 cast, or manually complement the constant. Larry -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
