Jason Andryuk <jandryuk@xxxxxxxxx> writes:
> On Wed, 2009-02-18 at 21:25 +0200, Kalle Valo wrote:
>> Jason Andryuk <jandryuk@xxxxxxxxx> writes:
>>
>> > cleanup dma on stack issues
>> >
>> > - no DMA on stack
>> > - cleanup unclear endianness issue
>> >
>> > Corrected version of Oliver Neukum's original patch for at76_usb
>>
>> Thanks, but the patch seems to be corrupted:
>>
>> patching file drivers/net/wireless/at76c50x-usb.c
>> Hunk #1 FAILED at 580.
>> patch: **** malformed patch at line 90: *udev, u16 mib, void *buf,
>>
>> Can you resend, please?
Thanks, this patch applied without problems.
You forgot to cc linux-wireless, adding it back.
> cleanup dma on stack issues
>
> - no DMA on stack
This looks good.
> - cleanup unclear endianness issue
I didn't find any endianness fixes from the patch. Did I just miss
them?
> @@ -1765,7 +1776,8 @@ static void at76_mac80211_stop(struct ieee80211_hw *hw)
> if (!priv->device_unplugged) {
> /* We are called by "ifconfig ethX down", not because the
> * device is not available anymore. */
> - at76_set_radio(priv, 0);
> + if (at76_set_radio(priv, 0) == 1)
> + at76_wait_completion(priv, CMD_RADIO_ON);
I think this is a separate from the dma issue and needs to have a
patch of it's own. I'll drop this part now.
I'll take the DMA part and do like with the previous patch, test it
and send it to John if everything is ok.
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
