On Sun, Feb 15, 2009 at 3:01 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Fri, 2009-02-13 at 21:33 -0800, Luis R. Rodriguez wrote: >> Calling kobject_uevent_env() can fail mainly due to out of >> memory conditions. We do not want to continue during such >> conditions so propagate that as well instead of letting >> cfg80211 load as if everything is peachy. >> >> Additionally lets clarify that when CRDA is not called during >> cfg80211's initialization _and_ if the error is not an -ENOMEM >> its because kobject_uevent_env() failed to call CRDA, not because >> CRDA failed. For those who want to find out why we also let you >> do so by enabling the kernel config CONFIG_CFG80211_REG_DEBUG -- >> you'll get an actual stack trace. >> >> So for now we'll treat non -ENOMEM kobject_uevent_env() failures as >> non fatal during cfg80211's initialization. > > I disagree with this patch -- there's so much that can go wrong even if > allocating the message here is ok that imho it's hardly useful to check > for errors here. Huh?? ENOMEM is the only error we are propagating -- that itself seems reasonable to propagate. > crda could fail, not be installed, etc. This is never propagated to the kernel, that is not what this patch does. Those failures you mentioned should not prevent cfg80211 from moving on. All this patch does is propagate -ENOMEMs. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
