On Fri, Feb 13, 2009 at 3:04 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Thu, 2009-02-12 at 21:36 -0800, Luis R. Rodriguez wrote: >> >> + if (wiphy_idx_valid(last_request->wiphy_idx)) >> + request_wiphy = wiphy_idx_to_wiphy(last_request->wiphy_idx); > > All this seems pointless, wiphy_idx_to_wiphy will just return NULL if > the index isn't valid. This is in a number of places, and it's not like > it being invalid will be happening often so we'd have to optimise for > it. The check can be removed if the WARNING is removed on wiphy_idx_to_wiphy(). I left it as I figured it'd be good to leave the warning, your call. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
