2009/2/13 Luis R. Rodriguez <mcgrof@xxxxxxxxx>: > On Fri, Feb 13, 2009 at 12:15 AM, Vitja Makarov <vitja.makarov@xxxxxxxxx> wrote: >> Hi! >> >> I was trying to build compat wireless for my arm board. >> First of all I disabled CONFIG_MAC80211 in my kernel, and successfully >> built compat-wireless. >> >> Then at runtime I get kernel panic. >> Then I found that sk_buff in 2.6.28 depends on CONFIG_MAC80211, so >> enabling it solves my problem. > > Ah nice catch. Well you're the first to try that and report it. > >> Shouldn't compat-wireless Makefile check kernel dot config for this >> option as well as for wireless extension? > > Yes, Can you send a patch, put some nasty warn on config.mk if its not > enabled on 2.6.28 and error out. > > Luis > Here is patch, sorry for attachment, firewall here blocks all email related ports. vitja.
diff --git a/config.mk b/config.mk index 49e82b3..f91f8f1 100644 --- a/config.mk +++ b/config.mk @@ -16,8 +16,6 @@ endif ifeq ($(CONFIG_MAC80211),y) $(error "ERROR: you have MAC80211 compiled into the kernel, CONFIG_MAC80211=y, as such you cannot replace its mac80211 driver. You need this set to CONFIG_MAC80211=m. If you are using Fedora upgrade your kernel as later version should this set as modular. For further information on Fedora see https://bugzilla.redhat.com/show_bug.cgi?id=470143. If you are using your own kernel recompile it and make mac80211 modular") endif -# Wireless subsystem stuff -CONFIG_MAC80211=m # We will warn when you don't have MQ support or NET_SCHED enabled. # @@ -44,6 +42,12 @@ $(error "ERROR: Your 2.6.27 kernel has CONFIG_DYNAMIC_FTRACE, please upgrade you endif endif +ifeq ($(shell test $(KERNEL_SUBLEVEL) -ge 28 && echo yes),yes) +ifeq ($(CONFIG_MAC80211),) +$(error "ERROR: Your >=2.6.28 kernel has CONFIG_MAC80211 disabled, you should have it CONFIG_MAC80211=m if you want to use this thing.") +endif +endif + ifneq ($(KERNELRELEASE),) # This prevents a warning ifeq ($(CONFIG_NET_SCHED),) @@ -59,6 +63,8 @@ endif endif # build check endif # kernel Makefile check +# Wireless subsystem stuff +CONFIG_MAC80211=m # choose between pid and minstrel as default rate control algorithm CONFIG_MAC80211_RC_DEFAULT=minstrel
