On Fri, Feb 13, 2009 at 12:08 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Thu, 2009-02-12 at 23:57 -0800, Luis R. Rodriguez wrote: > >> To answer that question -- reg_mutex just protects the >> reg_requests_list linked list. That's it. Without that you could >> potentially have two userspace reg hints while the workqueue runs. >> Remember that the hints no longer lock except to just add a new >> regulatory_request into the reg_requests_list. > > Right, ok. > >> >> Driver hint also does the same so it seems your fix on nl80211 would >> >> probably just tap this series on the nl80211_req_set_reg(). >> > >> > Yeah, I think I'll work on top of your series anyway so I don't clash >> > with the cleanups. >> >> Any other comments on the series? > > Not really, looks pretty good to me. It does seem a little dubious to > return an error from a hint function and then not attach the hardware, > but that's up to you what you want to do in ath9k I guess -- seems it > should work ok even if the hint failed, though of course then you'll not > have memory for anything else either... The only error is -ENOMEM so yeah we certainly should propagate that down to the driver. An alternative is to use a few regulatory_requests on the stack for queuing purposes but it just seemed silly on second thought. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
