Johannes Berg wrote:
On Fri, 2009-01-30 at 09:08 -0800, Luis R. Rodriguez wrote:
Monitor mode is able to TX by using injected frames. We should
not allow injected frames to be sent unless allowed by regulatory
rules. Since AP mode uses a monitor interfaces to transmit
management frames we have to take care to not break AP mode as
well while resolving this. We can deal with this by allowing compliant
APs solutions to inform mac80211 if their monitor interface is
intended to be used for an AP by setting a cfg80211 flag for the
monitor interface. hostapd, for example, currently does its own
checks to ensure AP mode is not used on channels which require radar
detection. Once such solutions are available it can can add this
flag for monitor interfaces.
Acked-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
Signed-off-by: Luis R. Rodriguez <lrodriguez@xxxxxxxxxxx>
Tested-by: Rick Farina <sidhayn@xxxxxxxxx>
Nacked-by: Rick Farina <sidhayn@xxxxxxxxx>
Luis, when I requested this from you and you cranked out a patch in 30
seconds what you gave me worked great, unfortunately this patch doesn't
perform the intended function for me. If I use this patch and mark,
say, everything as "PASSIVE-SCAN NO-IBSS" I can still send raw packets
out of my interface (confirmed by capturing on another card). The
original patch is as follows:
+ if ((tx->channel->flags & (IEEE80211_CHAN_NO_IBSS |
+ IEEE80211_CHAN_RADAR)))
+ return TX_DROP;
TX_DROP seemed to successfully prevent raw packet transmission on the
channels marked NO_IBSS. Can someone please confirm my findings so we
can get this fixed properly?
Thanks,
Rick Farina
---
This v6 leaves the AP flag out and removes the unused sdata..
Yeah, let's go with this until hostapd is fixed anyway.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
