On Sun, 2009-02-08 at 20:52 +0100, Florian Sesser wrote:
> Modularize mesh path selection protocol.
that's the subject, you also need to mentioned nl80211/cfg80211 since
that is the bulk of the change.
> This patch enables communication with userspace through the
> "iw" tool. The corresponding patch to IW will be posted on
> this list.
NACK to this description. 'iw' is but one implementation of an nl80211
userspace client.
> +++ b/include/net/cfg80211.h
> @@ -458,6 +458,10 @@ struct mesh_config {
> u32 dot11MeshHWMPactivePathTimeout;
> u16 dot11MeshHWMPpreqMinInterval;
> u16 dot11MeshHWMPnetDiameterTraversalTime;
> + /* Mesh IDs */
> + u32 mesh_path_selection_protocol_id;
> + u32 mesh_path_selection_metric_id;
> + u32 mesh_congestion_control_mode_id;
That's not a useful comment.
> + if (_chg_mesh_attr(NL80211_MESHCONF_PATH_SELECTION_PROTOCOL_ID, mask))
> + mesh_ids_set_pp(&sdata->u.mesh,
> + nconf->mesh_path_selection_protocol_id);
> + if (_chg_mesh_attr(NL80211_MESHCONF_PATH_SELECTION_METRIC_ID, mask))
> + conf->mesh_path_selection_metric_id =
> + nconf->mesh_path_selection_metric_id;
> + if (_chg_mesh_attr(NL80211_MESHCONF_CONGESTION_CONTROL_MODE_ID, mask))
> + conf->mesh_congestion_control_mode_id =
> + nconf->mesh_congestion_control_mode_id;
Shouldn't this actually effect the change too?
> + FILL_IN_MESH_PARAM_IF_SET(tb, cfg, mesh_path_selection_protocol_id,
> + mask, NL80211_MESHCONF_PATH_SELECTION_PROTOCOL_ID,
> + nla_get_u32);
> + FILL_IN_MESH_PARAM_IF_SET(tb, cfg, mesh_path_selection_metric_id,
> + mask, NL80211_MESHCONF_PATH_SELECTION_METRIC_ID,
> + nla_get_u32);
> + FILL_IN_MESH_PARAM_IF_SET(tb, cfg, mesh_congestion_control_mode_id,
> + mask, NL80211_MESHCONF_CONGESTION_CONTROL_MODE_ID,
> + nla_get_u32);
can that possibly be unset?
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
