Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: > On Fri, 2009-02-06 at 21:21 +0200, Kalle Valo wrote: >> "Alina Friedrichsen" <x-alina@xxxxxxx> writes: >> >> > The atomic requirement for the TSF callbacks is outdated. get_tsf() is >> > only called by ieee80211_rx_bss_info() which is indirectly called by >> > the work queue ieee80211_sta_work(). In the same context are called >> > several other non-atomic functions, too. And the atomic requirement >> > causes problems for drivers of USB wifi cards. >> >> Atomicity requirement also creates problems for SPI based devices, not >> only USB. So I strongly support for removing the requirement. >> >> Unfortunately I don't have time to review this, though. Sorry. > > It's ok, I took a look, there's no such requirement (any more). Oh good. Thanks for checking this. Alina, it would be nice to explicitly mention that the function can sleep. Otherwise driver authors need to guess if sleeping is allowed or not. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
