Search Linux Wireless

Re: [PATCH 5/5] ath5k: Update reset code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2009/2/5 Bob Copeland <me@xxxxxxxxxxxxxxx>:
> On Wed, 4 Feb 2009 23:57:06 +0200, Nick Kossifidis wrote
>> * Update reset and sync with HALs
>>  * Clean up eeprom settings and tweaking of initvals and put them on
> separate functions
>>  * Set/Restore 32KHz ref clk operation
>>  * Add some more documentation
>>  TODO: Spur mitigation, tpc, half/quarter rate, compression etc
>>
>>  v2: Address comments from Bob and Felix and fix RSSI threshold bug
>>  introduced on the first version of the patch
>>
>>  Signed-Off-by: Nick Kossifidis <mickflemm@xxxxxxxxx>
>
> This works much better, except I still get some hard hangs
> occasionally.  Doesn't appear to be bmiss storm this time.  I did it
> with a VT up and didn't get an oops; I guess I'll try a serial console
> or some printks.
>
> I could trigger it via a few suspend-resume cycles, so I guess it's the
> reset from ath5k_init().  Did you still have any problems with the 2425?
>

I think this is because we call reset too many times. Try removing
call to reset from config_interface, after some tests i did it seems
wrong (we don't need to reset pcu and if we do, we don't need to reset
the whole chip and re run phy initialization etc). I don't get any
problems with ar2425 but i didn't get any before anyway (i never got a
hang, just a few bmiss interrupts, not a storm).



-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux