On Thu, 2009-02-05 at 17:56 +0530, Vivek Natarajan wrote: > On Thu, Feb 5, 2009 at 5:37 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > On Thu, 2009-02-05 at 16:36 +0530, Vivek Natarajan wrote: > >> The warning message intended to be hit on driver's rejection of a Tx frame > >> is also hit while the netif_subqueue is stopped. This patch fixes this error > >> case. > > > > This seems a little odd. Why would we be in that code if the queue is > > stopped? > > This issue happens only when we are associated with a 11n AP and power > save is enabled. > In the function 'ieee80211_master_start_xmit', ps_disable_work is > queued where wake_queues is called. But before this work is executed, > we check if the queues are stopped in _ieee80211_tx and returned > TX_AGAIN to ieee8011_tx which led to the warning message. Ah, ok, thanks for the explanation. Might make sense to put that into the commit message. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
