On Thu, Feb 05, 2009 at 01:10:54PM +0100, Johannes Berg wrote: > Yeah, the truncation is a little worrying. I doubt any program but > wpa_supplicant is prepared to handle that. Should we completely remove > the entry, and add some new/custom piece to stream that indicates that > we had to truncate here? Well, the truncation is partly an artifact of the way iwe_stream_* helpers work and I would expect all drivers to be doing this already (should they support large enough number of BSSes to hit the limit). If I have understood correctly, truncation happens between events, i.e., no event (struct iw_event) itself is truncated; some events are just missing from a BSS. As such, I would expect more or less all application to handle that one way or another. They may assume the network does not support WPA etc. based on some iw_events missing, but that should be about it. It would be somewhat cleaner to truncate between BSSes instead of between iw_events, but it would be some more code (remember the length before starting to add new BSS and use it if truncations was detected). I don't think I would bother with custom iw_event stating that truncation happened since I do not see much use for it in wpa_supplicant. It could be of some use for someone running iwlist scan manually. -- Jouni Malinen PGP id EFC895FA -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
